T1311329 - DataGrid - Column chooser hides a banded column on using search and recursive selection#32186

Merged

dmirgaev merged 14 commits intoDevExpress:26_1from

Raushen:T1311329_26_1

Jan 19, 2026

Contributor

Raushen commented Jan 13, 2026

No description provided.

Raushen self-assigned this

Raushen requested a review from a team as a code owner

January 13, 2026 22:42

Raushen added type/bug 26_1 labels

Copilot AI review requested due to automatic review settings

January 13, 2026 22:42

Copilot started reviewing on behalf of Raushen

January 13, 2026 22:43

Copilot AI reviewed

View reviewed changes

Contributor

Copilot AI left a comment

Pull request overview

This PR fixes a bug (T1311329) where the DataGrid column chooser incorrectly hides a banded (parent) column when using search functionality with recursive selection enabled. The issue occurred because column visibility was being updated without considering the relationship between banded columns and their children.

Changes:

Refactored column visibility update logic to handle banded columns correctly by processing them in sorted order (non-band columns first, then band columns)
Added integration tests to verify the fix for both the search scenario and direct toggling of banded columns
Created reusable test model classes (TreeViewModel, TextBoxModel, CheckBoxModel, ColumnChooserModel) to support the new tests

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
packages/devextreme/js/__internal/grids/grid_core/column_chooser/m_column_chooser.ts	Refactored column visibility logic to correctly handle banded columns by sorting nodes and determining visibility based on child column states
packages/devextreme/js/__internal/grids/grid_core/column_chooser/tests/column_chooser.integration.test.ts	Added comprehensive integration tests for the banded column visibility fix
packages/devextreme/js/__internal/grids/grid_core/tests/mock/model/grid_core.ts	Added getColumnChooser method to support column chooser testing
packages/devextreme/js/__internal/grids/grid_core/tests/mock/model/column_chooser.ts	Created model class for interacting with column chooser in tests
packages/devextreme/js/__internal/ui/tests/mock/model/tree_view.ts	Created reusable model for TreeView interactions in tests
packages/devextreme/js/__internal/ui/tests/mock/model/textbox.ts	Created reusable model for TextBox interactions in tests
packages/devextreme/js/__internal/ui/tests/mock/model/checkbox.ts	Created reusable model for CheckBox interactions in tests

packages/devextreme/js/__internal/grids/grid_core/column_chooser/m_column_chooser.ts Outdated Show resolved Hide resolved

packages/devextreme/js/__internal/grids/grid_core/column_chooser/m_column_chooser.ts Show resolved Hide resolved

packages/devextreme/js/__internal/ui/__tests__/__mock__/model/tree_view.ts Show resolved Hide resolved

packages/devextreme/js/__internal/grids/grid_core/__tests__/__mock__/model/column_chooser.ts Show resolved Hide resolved

anna-shakhova reviewed

View reviewed changes

...me/js/__internal/grids/grid_core/column_chooser/__tests__/column_chooser.integration.test.ts Show resolved Hide resolved

anna-shakhova reviewed

View reviewed changes

packages/devextreme/js/__internal/grids/grid_core/column_chooser/m_column_chooser.ts Outdated Show resolved Hide resolved

anna-shakhova reviewed

View reviewed changes

packages/devextreme/js/__internal/grids/grid_core/column_chooser/m_column_chooser.ts Show resolved Hide resolved

Copilot AI review requested due to automatic review settings

January 15, 2026 02:25

Copilot started reviewing on behalf of Raushen

January 15, 2026 02:25

Copilot AI reviewed

View reviewed changes

Contributor

Copilot AI left a comment

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.

packages/devextreme/js/__internal/grids/grid_core/column_chooser/m_column_chooser.ts Show resolved Hide resolved

packages/devextreme/js/__internal/grids/grid_core/column_chooser/m_column_chooser.ts Outdated Show resolved Hide resolved

packages/devextreme/js/__internal/ui/__tests__/__mock__/model/tree_view.ts Show resolved Hide resolved

Copilot AI review requested due to automatic review settings

January 15, 2026 03:21

Copilot started reviewing on behalf of Raushen

January 15, 2026 03:21

Copilot AI reviewed

View reviewed changes

Contributor

Copilot AI left a comment

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.

packages/devextreme/js/__internal/grids/grid_core/column_chooser/m_column_chooser.ts Outdated Show resolved Hide resolved

packages/devextreme/js/__internal/ui/__tests__/__mock__/model/tree_view.ts Show resolved Hide resolved

...me/js/__internal/grids/grid_core/column_chooser/__tests__/column_chooser.integration.test.ts Show resolved Hide resolved

Raushen added the skip-cache label

anna-shakhova reviewed

View reviewed changes

packages/devextreme/js/__internal/grids/grid_core/column_chooser/m_column_chooser.ts Outdated Show resolved Hide resolved

Copilot AI review requested due to automatic review settings

January 16, 2026 06:32

Copilot started reviewing on behalf of dmirgaev

January 16, 2026 06:32

Copilot AI reviewed

View reviewed changes

Contributor

Copilot AI left a comment

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated 6 comments.

...me/js/__internal/grids/grid_core/column_chooser/__tests__/column_chooser.integration.test.ts Show resolved Hide resolved

packages/devextreme/js/__internal/ui/__tests__/__mock__/model/tree_view.ts Show resolved Hide resolved

packages/devextreme/js/__internal/grids/grid_core/column_chooser/m_column_chooser.ts Show resolved Hide resolved

packages/devextreme/js/__internal/ui/__tests__/__mock__/model/textbox.ts Show resolved Hide resolved

...me/js/__internal/grids/grid_core/column_chooser/__tests__/column_chooser.integration.test.ts Show resolved Hide resolved

dmirgaev force-pushed the T1311329_26_1 branch from 0b2e291 to ceb624a Compare

January 16, 2026 07:51

anna-shakhova reviewed

View reviewed changes

packages/devextreme/js/__internal/grids/grid_core/column_chooser/m_column_chooser.ts Outdated Show resolved Hide resolved

dmirgaev force-pushed the T1311329_26_1 branch from ceb624a to 779d885 Compare

January 16, 2026 17:43

Copilot AI review requested due to automatic review settings

January 16, 2026 17:43

Copilot started reviewing on behalf of dmirgaev

January 16, 2026 17:43

Copilot AI reviewed

View reviewed changes

Contributor

Copilot AI left a comment

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated 5 comments.

packages/devextreme/js/__internal/grids/grid_core/column_chooser/m_column_chooser.ts Show resolved Hide resolved

packages/devextreme/js/__internal/grids/grid_core/column_chooser/m_column_chooser.ts Show resolved Hide resolved

packages/devextreme/js/__internal/grids/grid_core/__tests__/__mock__/model/column_chooser.ts Show resolved Hide resolved

...me/js/__internal/grids/grid_core/column_chooser/__tests__/column_chooser.integration.test.ts

+                    visibleColumnsLevel0 = instance.getVisibleColumns(0);
+                    visibleColumnsLevel1 = instance.getVisibleColumns(1);
+                    expect(visibleColumnsLevel0.find((col) => col.caption === 'Contacts')).toBeDefined();

Copilot AI Jan 16, 2026

The test uses .toBeDefined() which passes even when find() returns undefined. This assertion will always pass because find() always returns a value (either an object or undefined), and undefined.toBeDefined() is true. Use .toBeTruthy() or check the result with .not.toBeUndefined() for the intended behavior.

Copilot uses AI. Check for mistakes.

...me/js/__internal/grids/grid_core/column_chooser/__tests__/column_chooser.integration.test.ts Show resolved Hide resolved

dmirgaev added skip-cache and removed skip-cache labels


          Ad test

394da24

Raushen and others added 13 commits

January 19, 2026 18:16


          T1311329

b9a58ce


          Fix click on band column

f3f1b96


          Add comment

91950c4


          Fix test

092b536


          Add types

78217d3


          Add three band level test

cccfac0


          Refactoring

d2c1000


          Refactoring

c602c33


          Rename method

2c4d336


          Test commit

bf10849


          simplify the logic and rename private methods

c5feb57


          fix type warning

9ab1dca


          rename methods

3bb66d2

Copilot AI review requested due to automatic review settings

January 19, 2026 14:17

dmirgaev force-pushed the T1311329_26_1 branch from 26523fe to 3bb66d2 Compare

January 19, 2026 14:17

Copilot started reviewing on behalf of dmirgaev

January 19, 2026 14:18

Copilot AI reviewed

View reviewed changes

Contributor

Copilot AI left a comment

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated no new comments.

anna-shakhova approved these changes

View reviewed changes

dmirgaev merged commit 5e47317 into DevExpress:26_1

99 of 100 checks passed

dmirgaev added a commit to dmirgaev/DevExtreme that referenced this pull request


          T1311329 - DataGrid - Column chooser hides a banded column on using s…

50665f1

…earch and recursive selection (DevExpress#32186)

Co-authored-by: Danil Mirgaev <danil.mirgaev@devexpress.com>

dmirgaev added a commit to dmirgaev/DevExtreme that referenced this pull request


          T1311329 - DataGrid - Column chooser hides a banded column on using s…

92588f5

…earch and recursive selection (DevExpress#32186)

Co-authored-by: Danil Mirgaev <danil.mirgaev@devexpress.com>

dmirgaev added a commit that referenced this pull request


          T1311329 - DataGrid - Column chooser hides a banded column on using s…

f00e956

…earch and recursive selection (#32186) (#32237)

Co-authored-by: Andrey Dolzhikov <16618553+Raushen@users.noreply.github.com>

dmirgaev added a commit that referenced this pull request


          T1311329 - DataGrid - Column chooser hides a banded column on using s…

f7dbe2a

…earch and recursive selection (#32186) (#32238)

Co-authored-by: Andrey Dolzhikov <16618553+raushen@users.noreply.github.com>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

26_1 skip-cache type/bug